Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better handling of networking failures. #630

Open
lazysegtree opened this issue Feb 20, 2025 · 0 comments · May be fixed by #632
Open

Need better handling of networking failures. #630

lazysegtree opened this issue Feb 20, 2025 · 0 comments · May be fixed by #632
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lazysegtree
Copy link
Collaborator

Issue 1

We are printing errors out instead of logging. Its not that critical of an error that should be showed directly to the user

➜  ~/Workspace/Other_proj/BhagatHarsh/superfile git:(upgrade_sidebar_search) ✗ [7:20:22] bspf
Error checking for updates: Get "https://api.github.com/repos/yorukot/superfile/releases/latest": dial tcp: lookup api.github.com: no such host
➜  ~/Workspace/Other_proj/BhagatHarsh/superfile git:(upgrade_sidebar_search) ✗ [7:20:25]

Issue 2

We must set a timeout in case of internet issues, where requests just gets stuck forever. I just opened spf and exited (while my internet was bad), and it was stuck for at least 20 seconds before I cancelled it.

➜ ~ [7:38:42] spf
^C%
➜ ~ [7:39:02]

@lazysegtree lazysegtree added bug Something isn't working good first issue Good for newcomers labels Feb 20, 2025
@lazysegtree lazysegtree changed the title Need to handle networking failures. Need better handling of networking failures. Feb 20, 2025
@jachewz jachewz linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant