Should we use @cloudflare/vite-plugin instead?

[agcty]

The new cloudflare vite plugin just came out and it feels like we should maybe use that instead?
Also could it be that it's based on your code since you're a DA for Cloudflare?

In any case it's now much easier to deploy react router to cloudflare

[yusukebe]

Hi @agcty

The new cloudflare vite plugin just came out and it feels like we should maybe use that instead?

Yes. Ideally, we should use it. But this hono-react-router-adapter depends on @hono/vite-dev-server, so it's not easy to use it. I'll work on it later.

[firxworx]

Related discussion in #67

I noticed the Cloudflare official examples were recently updated to all use the @cloudflare/vite-plugin, refer to https://github.com/cloudflare/templates/tree/staging/react-router-starter-template + https://github.com/cloudflare/templates/tree/staging/react-router-postgres-ssr-template among others.

I think these provide a quality reference because many of the examples use hono!

I recently made a repo with rr + hono backend that follows the new approach with @cloudflare/vite-plugin in https://github.com/firxworx/rr7-i18next which is similar to what I saw in https://github.com/tobiasfoerg/cf-template/ (and now I realize the author must have been looking at the new official Cloudflare templates).

The difference between these two latter examples is mine doesn't adopt the new unstable middleware whereas the latter does. The unstable middleware changes the type of the react router context from AppLoadContext to one based on a Map.

I think its good to support both context types, which are differentiated based on the declare 'react-router' type augmentation with interface Future { ... }).

Heads up there are open discussions in react-router that could change the new context type, and it is unstable after all.

The community package https://github.com/rphlmr/react-router-hono-server has some interesting tidbits in it for both node and cloudflare e.g. https://github.com/rphlmr/react-router-hono-server/blob/main/src/adapters/cloudflare.ts and also handing react-router v7 friendly redirects https://github.com/rphlmr/react-router-hono-server/blob/main/src/http.ts

[yusukebe]

I have some ideas, though I don't know if they can solve it. I'll work on it later.

[yusukebe]

Hi @agcty @firxworx

I'm sorry to be late.

For now, I think we should deprecate this hono-react-router-adapter and encourage using @cloudflare/vite-plugin instead. Using @cloudflare/vite-plugin, you don't need @hono/vite-dev-server, and it can support more Cloudflare stacks like Durable Objects.

You can refer to the example below, which uses them:

https://github.com/chimame/react-router-template-for-hono-adapter