Remove legacy autocompletion with Kibana spec

Author: pquentin

HISTORY.rst

@@ -2,6 +2,13 @@
 History
 =======
 
+0.3.0 (unreleased)
+------------------
+
+* Drop legacy Kibana autocompletion support
+* Drop Python 3.8 and 3.9 support
+* Support Python 3.11 to 3.14
+
 0.2.2 (2021-02-28)
 ------------------
 

Makefile

@@ -30,13 +30,6 @@ get-specs:
 	mkdir -p peek/specs
 	curl -L https://raw.githubusercontent.com/elastic/elasticsearch-specification/8.2/output/schema/schema.json -o peek/specs/schema.json
 
-get-specs-legacy:
-	rm -rf $$TMPDIR/kibana-7.8.1.zip
-	curl -L https://github.com/elastic/kibana/archive/v7.8.1.zip -o $$TMPDIR/kibana-7.8.1.zip
-	mkdir -p peek/specs
-	unzip -o $$TMPDIR/kibana-7.8.1.zip -d peek/specs '*/lib/spec_definitions/j*'
-	rm -rf $$TMPDIR/kibana-7.8.1.zip
-
 clean: clean-build clean-pyc clean-test ## remove all build, test, coverage and Python artifacts
 
 clean-build: ## remove build artifacts

docs/usage.rst

@@ -141,15 +141,6 @@ Peek however does not ship with the spec file. Use the builtin function, ``_down
 to download and initialize the spec file from its GitHub official repository.
 The spec file is saved in Peek's config folder so you only need to run the function once.
 
-Legacy auto-completion with Kibana spec files
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-Prior to v0.3.0, autocompletion uses API spec files published by the
-`Kibana project <https://github.com/elastic/kibana>`_. This is disabled by default.
-It can still be enabled (*NOT recommended*) by setting
-``prefer_elasticsearch_specification = False``. This also changes the behaviour of
-``_download_api_specs`` to download Kibana spec files instead.
-
-
 Functions
 ---------
 

peek/completer.py

@@ -149,35 +149,18 @@ def init_api_completer(self):
         from peek import __file__ as package_root
 
         package_root = os.path.dirname(package_root)
-        if self.app.config.as_bool('prefer_elasticsearch_specification'):
-            _logger.info('Use elasticsearch-specification schema for autocompletion')
-            from peek.es_api_spec.api_completer import SchemaESApiCompleter
-
-            schema_filepath = os.path.join(config_location(), 'schema.json')
-            if not os.path.exists(schema_filepath):
-                schema_filepath = os.path.join(package_root, 'specs', 'schema.json')
-            if os.path.exists(schema_filepath):
-                return SchemaESApiCompleter(schema_filepath)
-            else:
-                from peek.es_api_spec.api_completer import NoopESApiCompleter
-
-                return NoopESApiCompleter()
+        _logger.info('Use elasticsearch-specification schema for autocompletion')
+        from peek.es_api_spec.api_completer import SchemaESApiCompleter
+
+        schema_filepath = os.path.join(config_location(), 'schema.json')
+        if not os.path.exists(schema_filepath):
+            schema_filepath = os.path.join(package_root, 'specs', 'schema.json')
+        if os.path.exists(schema_filepath):
+            return SchemaESApiCompleter(schema_filepath)
         else:
-            kibana_dir = self.app.config['kibana_dir']
-            if not kibana_dir:
-                config_dir = config_location()
-                if os.path.exists(config_dir):
-                    kibana_dirs = [
-                        os.path.join(config_dir, d) for d in os.listdir(config_dir) if d.startswith('kibana-')
-                    ]
-                    if kibana_dirs:
-                        kibana_dir = kibana_dirs[0]
-            if not kibana_dir:
-                kibana_dir = os.path.join(package_root, 'specs', 'kibana-7.8.1')
-            _logger.info(f'Attempt to build Elasticsearch API specs from: {kibana_dir}')
-            from peek.es_api_spec.kspec import KibanaSpecESApiCompleter
-
-            return KibanaSpecESApiCompleter(self.app, kibana_dir)
+            from peek.es_api_spec.api_completer import NoopESApiCompleter
+
+            return NoopESApiCompleter()
 
     def get_completions(self, document: Document, complete_event: CompleteEvent) -> Iterable[Completion]:
         _logger.debug(f'Document: {document}, Event: {complete_event}')