Question: How to get access to original HttpServletRequest from zalando HttpRequest

[metalpalo]

We have implemented custom sink for logbook logging(version 2.13.0):

@Bean
Sink customizedLogbookSink(HttpLogFormatter formatter, HttpLogWriter writer) {
    return new CustomSink(formatter, writer);
  }

Within this class is is possibe to get HttpRequest from zalando library but we want to have get original HttpServletRequest which is wrapped in 3rd level via delegate method.

Is possible to simply get this class if exists and get access to its attributes? For this moment when debuging it following code works for me but it can depend in concrete release or configuration:

if (request instanceof ForwardingHttpRequest) {//FilteredHttpRequest
        HttpRequest delegate1 = ((ForwardingHttpRequest) request).delegate();

        if (delegate1 instanceof ForwardingHttpRequest) {//CachingHttpRequest
          HttpRequest delegate2 = ((ForwardingHttpRequest) delegate1).delegate();

          if (delegate2 instanceof HttpServletRequest) {//RemoteRequest
            HttpServletRequest servletRequest = ((HttpServletRequest) delegate2);
            Object attribute = servletRequest.getAttribute("importantAttributeKey");
            System.out.println(attribute);
          }
        }
      }

thanks

[kasmarian]

The wrapped request class can be very different depending on the service or client library that's used to process HTTP calls. That's why Logbook converts the requests/responses to an internal interface to work with.

If you need to have access to an attribute from a request in your Sink, you could try using an Attribute Extractor to extract the attribute and put it in the Logbook's request object and then to have access to it in your custom Sink.

[metalpalo]

I dont understand, within the controller method HttpServletRequest instance is provided and call setAttribute method on it with "importantAttributeKey" value for instance.
Now I want to have access to it from sink .

When looking at attribute extractor interface it accepts again HttpRequest from logbook library so how to do it there?
thanks

[kasmarian]

Yes, you're right, you'd require casting here either way.
Potentially we could add an implementation for public HttpAttributes getAttributes() method in RemoteRequest similar to the way it was done in #1805 for ClientRequest. That way you'd be able to get access to the attributes of the request/response objects (you'd still need to use the attribute extractor (or use AllAttributesExtractor) to transfer attributes from the original request object to the wrapper.