Skip to content
This repository was archived by the owner on Mar 21, 2022. It is now read-only.

Commit ffbef69

Browse files
committed
fix tests with proper django timezone support
1 parent 11173f6 commit ffbef69

File tree

2 files changed

+23
-19
lines changed

2 files changed

+23
-19
lines changed

drip/tests.py

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from django.core.urlresolvers import resolve, reverse
77
from django.core import mail
88
from django.conf import settings
9+
from django.utils import timezone
910

1011
from drip.models import Drip, SentDrip, QuerySetRule
1112
from drip.drips import DripBase, DripMessage
@@ -44,7 +45,7 @@ def setUp(self):
4445
"""
4546
self.User = get_user_model()
4647

47-
start = datetime.now() - timedelta(hours=2)
48+
start = timezone.now() - timedelta(hours=2)
4849
num_string = ['first','second','third','fourth','fifth','sixth','seventh','eighth','ninth','tenth']
4950

5051
for i, name in enumerate(num_string):
@@ -63,43 +64,43 @@ def test_users_exists(self):
6364
self.assertEqual(20, self.User.objects.all().count())
6465

6566
def test_day_zero_users(self):
66-
start = datetime.now() - timedelta(days=1)
67-
end = datetime.now()
67+
start = timezone.now() - timedelta(days=1)
68+
end = timezone.now()
6869
self.assertEqual(2, self.User.objects.filter(date_joined__range=(start, end)).count())
6970

7071
def test_day_two_users_active(self):
71-
start = datetime.now() - timedelta(days=3)
72-
end = datetime.now() - timedelta(days=2)
72+
start = timezone.now() - timedelta(days=3)
73+
end = timezone.now() - timedelta(days=2)
7374
self.assertEqual(1, self.User.objects.filter(date_joined__range=(start, end),
7475
profile__credits__gt=0).count())
7576

7677
def test_day_two_users_inactive(self):
77-
start = datetime.now() - timedelta(days=3)
78-
end = datetime.now() - timedelta(days=2)
78+
start = timezone.now() - timedelta(days=3)
79+
end = timezone.now() - timedelta(days=2)
7980
self.assertEqual(1, self.User.objects.filter(date_joined__range=(start, end),
8081
profile__credits=0).count())
8182

8283
def test_day_seven_users_active(self):
83-
start = datetime.now() - timedelta(days=8)
84-
end = datetime.now() - timedelta(days=7)
84+
start = timezone.now() - timedelta(days=8)
85+
end = timezone.now() - timedelta(days=7)
8586
self.assertEqual(1, self.User.objects.filter(date_joined__range=(start, end),
8687
profile__credits__gt=0).count())
8788

8889
def test_day_seven_users_inactive(self):
89-
start = datetime.now() - timedelta(days=8)
90-
end = datetime.now() - timedelta(days=7)
90+
start = timezone.now() - timedelta(days=8)
91+
end = timezone.now() - timedelta(days=7)
9192
self.assertEqual(1, self.User.objects.filter(date_joined__range=(start, end),
9293
profile__credits=0).count())
9394

9495
def test_day_fourteen_users_active(self):
95-
start = datetime.now() - timedelta(days=15)
96-
end = datetime.now() - timedelta(days=14)
96+
start = timezone.now() - timedelta(days=15)
97+
end = timezone.now() - timedelta(days=14)
9798
self.assertEqual(0, self.User.objects.filter(date_joined__range=(start, end),
9899
profile__credits__gt=0).count())
99100

100101
def test_day_fourteen_users_inactive(self):
101-
start = datetime.now() - timedelta(days=15)
102-
end = datetime.now() - timedelta(days=14)
102+
start = timezone.now() - timedelta(days=15)
103+
end = timezone.now() - timedelta(days=14)
103104
self.assertEqual(0, self.User.objects.filter(date_joined__range=(start, end),
104105
profile__credits=0).count())
105106

@@ -242,7 +243,7 @@ def test_custom_drip_static_datetime(self):
242243
drip=model_drip,
243244
field_name='date_joined',
244245
lookup_type='lte',
245-
field_value=(datetime.now() - timedelta(days=8)).strftime('%Y-%m-%d %H:%M:%S')
246+
field_value=(timezone.now() - timedelta(days=8)).strftime('%Y-%m-%d %H:%M:%S')
246247
)
247248
drip = model_drip.drip
248249

@@ -259,7 +260,7 @@ def test_custom_drip_static_now_datetime(self):
259260
drip=model_drip,
260261
field_name='date_joined',
261262
lookup_type='gte',
262-
field_value=(datetime.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
263+
field_value=(timezone.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
263264
)
264265
drip = model_drip.drip
265266

@@ -284,7 +285,7 @@ def test_admin_timeline_prunes_user_output(self):
284285
drip=model_drip,
285286
field_name='date_joined',
286287
lookup_type='gte',
287-
field_value=(datetime.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
288+
field_value=(timezone.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
288289
)
289290

290291
# then get it's admin view.
@@ -398,7 +399,7 @@ def test_apply_multiple_rules_with_aggregation(self):
398399
drip=model_drip,
399400
field_name='date_joined',
400401
lookup_type='gte',
401-
field_value=(datetime.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
402+
field_value=(timezone.now() - timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')
402403
)
403404

404405

testsettings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
'django.middleware.clickjacking.XFrameOptionsMiddleware',
3838
)
3939

40+
USE_TZ = True
41+
TIME_ZONE = 'UTC'
42+
4043
AUTH_PROFILE_MODULE = 'credits.Profile'
4144

4245
ROOT_URLCONF = 'test_urls'

0 commit comments

Comments
 (0)