Skip to content

Conversation

@dominikl
Copy link
Contributor

@dominikl dominikl commented Nov 5, 2025

  • Load the attributes of the v2 GroupMetadata.
  • Make them available on the GroupMetadata interface level via attributes()
  • Also make the Groupmetadata availabe via Group.metadata()

To test:

String path = "https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0073A/";
String zarr = "9798462.zarr";
StoreHandle handle = new HttpStore(path).resolve(zarr);
Group group = Group.open(handle);
System.out.println(group.metadata().attributes());

(address issue #23 (comment) )

@dominikl
Copy link
Contributor Author

dominikl commented Nov 5, 2025

@brokkoli71 Please don't hesitate to just close this PR in case you're already working on that too! :-)

@brokkoli71
Copy link
Member

I wasn't. Thanks for adding it! :)

@brokkoli71 brokkoli71 self-requested a review November 7, 2025 10:11
Copy link
Member

@brokkoli71 brokkoli71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! In case you're not currently working on this, I'll merge it, apply the requested changes there, and add some tests.

@dominikl
Copy link
Contributor Author

dominikl commented Nov 7, 2025

Thank you very much. Yes, sorry, haven't got round to add test for this.

@brokkoli71 brokkoli71 merged commit f018f0a into zarr-developers:v2-attributes Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants