remote: Flush to stdin when writing to sftp 2 (#42126) (cherry-pick to preview) (#42187)

zed-zippy[bot] · Veykril · web-flow · commit c21c47e8eff2 · 2025-11-07T13:28:41.000+01:00
Cherry-pick of #42126 to preview ---- #42103 (comment) Release Notes: - N/A *or* Added/Fixed/Improved ... Co-authored-by: Lukas Wirth <lukas@zed.dev>
diff --git a/crates/remote/src/transport/ssh.rs b/crates/remote/src/transport/ssh.rs
@@ -306,7 +306,7 @@ impl RemoteConnection for SshRemoteConnection {
                     use futures::AsyncWriteExt;
                     let sftp_batch = format!("put -r {src_path_display} {dest_path_str}\n");
                     stdin.write_all(sftp_batch.as_bytes()).await?;
-                    drop(stdin);
+                    stdin.flush().await?;
                 }
 
                 let output = child.output().await?;

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ impl RemoteConnection for SshRemoteConnection {`
`306`	`306`	`use futures::AsyncWriteExt;`
`307`	`307`	`let sftp_batch = format!("put -r {src_path_display} {dest_path_str}\n");`
`308`	`308`	`stdin.write_all(sftp_batch.as_bytes()).await?;`
`309`		`- drop(stdin);`
	`309`	`+ stdin.flush().await?;`
`310`	`310`	`}`
`311`	`311`
`312`	`312`	`let output = child.output().await?;`