Fix bank not found error

Author: Theodore Li

kotlin/lambda/item-handler/src/main/kotlin/com/zenobiapay/item/operations/GetItemOperation.kt

@@ -5,6 +5,7 @@ import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent
 import com.zenobiapay.api.generated.model.GetItemRequest
 import com.zenobiapay.api.generated.model.Item
 import com.zenobiapay.api.model.cognito.UserPoolGroup
+import com.zenobiapay.api.model.exception.InvalidRequestException
 import com.zenobiapay.api.model.exception.ResourceNotFoundException
 import com.zenobiapay.api.operation.Operation
 import com.zenobiapay.item.util.S3UrlGenerator
@@ -23,7 +24,12 @@ class GetItemOperation @Inject constructor(
         context: Context,
         userId: String?
     ): Item {
-        val item = rdsWrapper.getItem(UUID.fromString(request.itemId)) ?: throw ResourceNotFoundException("ITEM")
+        val uuidItem = try { 
+            UUID.fromString(request.itemId)
+        } catch (e: IllegalArgumentException) {
+            throw InvalidRequestException("Invalid item ID format")
+        }
+        val item = rdsWrapper.getItem(uuidItem) ?: throw ResourceNotFoundException("ITEM")
 
         return Item()
             .itemId(item.itemId.toString())

kotlin/lambda/transfer-handler/src/main/kotlin/com/zenobiapay/transfer/operations/FulfillTransferOperation.kt

@@ -93,6 +93,9 @@ class FulfillTransferOperation @Inject constructor(
         } catch (e: software.amazon.awssdk.services.dynamodb.model.ResourceNotFoundException) {
             logger.info { "Could not find bank id $bankAccountId" }
             throw ResourceNotFoundException("BANK_ACCOUNT")
+        } catch (e: NullPointerException) {
+            logger.info { "Bank account not found for userId $userId, bankAccountId $bankAccountId, deviceId ${request.deviceId}" }
+            throw ResourceNotFoundException("BANK_ACCOUNT")
         }
 
         if (customerBankAccountItem.data.bankPermissions != BankPermissions.SEND_ONLY) {

sql/add-item-and-transfer-fields.sql

@@ -4,5 +4,5 @@ ALTER TABLE items
     ADD COLUMN IF NOT EXISTS color TEXT,
     ADD COLUMN IF NOT EXISTS material TEXT,
     ADD COLUMN IF NOT EXISTS year TEXT,
-    ADD COLUMN IF NOT EXISTS image_keys TEXT[];
+    ADD COLUMN IF NOT EXISTS image_keys TEXT[],
     ADD COLUMN IF NOT EXISTS resale_job_id TEXT;