Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button support for frdm_mcxw71 #86736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix button support for frdm_mcxw71 #86736

wants to merge 1 commit into from
+1 −1

Conversation

EmilioCBen
Copy link
Contributor

@EmilioCBen EmilioCBen commented Mar 6, 2025 •
edited
Loading

Fixes #86735
SW2 Needed the GPIO_PULL_UP flag to be set.

@EmilioCBen EmilioCBen added this to the v4.1.0 milestone Mar 6, 2025
@EmilioCBen EmilioCBen requested review from dleach02 and decsny March 6, 2025 16:31
@EmilioCBen EmilioCBen added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 6, 2025
@EmilioCBen
Copy link
Contributor Author

@fabiobaltieri would this be able to get into 4.1 by any chance?

@fabiobaltieri
Copy link
Member

It's a bit on the late side, is this correct btw? SW2 appears to be on gpioc 6

@EmilioCBen EmilioCBen removed the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Mar 6, 2025
@EmilioCBen EmilioCBen removed this from the v4.1.0 milestone Mar 6, 2025
@EmilioCBen
Copy link
Contributor Author

It's a bit on the late side, is this correct btw? SW2 appears to be on gpioc 6

You are correct, I need to look at this more gpioc alone for some reason does not allow the button to function correctly.

@EmilioCBen EmilioCBen added the DNM This PR should not be merged (Do Not Merge) label Mar 6, 2025
mmahadevan108
mmahadevan108 previously approved these changes Mar 6, 2025
View reviewed changes
@fabiobaltieri
Copy link
Member

You are correct, I need to look at this more gpioc alone for some reason does not allow the button to function correctly.

Ok, it seems like the issue is somewhere else, let's not rush, see if you can figure what is actually wrong and then fix it properly and backport it.

@fabiobaltieri fabiobaltieri added this to the v4.2.0 milestone Mar 6, 2025
@EmilioCBen
boards: nxp: frdm_mcxw71: Adding Pull Up flag
080cbba 
The SW2 needs the PULL UP flag to be set to be
enabled.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen EmilioCBen force-pushed the fix/frdm_mcxw71_button branch from eec3b46 to 080cbba Compare March 7, 2025 18:01
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Mar 7, 2025
@EmilioCBen
Copy link
Contributor Author

This PR has now been updated with correct change.

fabiobaltieri
fabiobaltieri approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm even more confused by how it could have possibly worked by enabling the gpioa device but ok, this makes sense.

@fabiobaltieri fabiobaltieri removed the DNM This PR should not be merged (Do Not Merge) label Mar 7, 2025
@decsny
Copy link
Member

decsny commented Mar 7, 2025 •
edited
Loading

Now I'm even more confused by how it could have possibly worked by enabling the gpioa device but ok, this makes sense.

the pin was floating, so literally just breathing on it could change the button behavior, and enabling another thing on the device could also, so I can see where the confusion came from

@kartben kartben added the backport v4.1-branch Request backport to the v4.1-branch label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@decsny decsny decsny approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 left review comments

@dleach02 dleach02 Awaiting requested review from dleach02

@butok butok Awaiting requested review from butok

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels
backport v4.1-branch Request backport to the v4.1-branch platform: NXP NXP size: XS A PR changing only a single line of code
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

frdm_mcxw71 Button is not working.
8 participants
@EmilioCBen @fabiobaltieri @decsny @henrikbrixandersen @mmahadevan108 @kartben @zephyrbot @dleach02