-
Notifications
You must be signed in to change notification settings - Fork 35
Support for touch events? #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@DSheffield It does work on mobile devices - if that's what you're asking. Is there a specific reason you need touch events? |
I see from your simple demo app it does seem to work with touch (or at least the corresponding mouse events the browser sends when touches occur). We've used the addon in our app and it seemed it wasn't invoking the clickOutside action in response to touch events. But, maybe we've done something that's interfering with the events. I'll check into that a bit further. We need touch events cause our app is kinda positioned as touch based - but we're using touch screen laptops (not phones / ipads, etc). |
So you need the same click behavior on touch-based devices? |
Yeah, effectively I want the clickOutside action to be triggered any time there's any kind of touch interaction not within my component. |
To be honest I did not have such goals :) Nevertheless, if you have working fork supporting this -and it does fit into the original addon's API- I'm happy to pull the changes to upstream! |
What is your browser / version support goal? |
It's not quite about browser support per se. The way I think about this is more of how mobile browsers are handling these interactions with the current version. They do support clicks on elements, so the current behavior is not buggy. That said, if there was a setting, like |
@DSheffield Can be achieved with #51 |
Is there any plan to support touch events as well? So click outside could effectively be click or touch outside?
The text was updated successfully, but these errors were encountered: