discovery(openstack): remove duplicated error handling for floatingips.List (prometheus#16205)

paulojmdias · web-flow · commit 9630dc656c39 · 2025-03-12T15:25:50.000+01:00
Signed-off-by: Paulo Dias &lt;paulodias.gm@gmail.com&gt;
diff --git a/discovery/openstack/loadbalancer.go b/discovery/openstack/loadbalancer.go
@@ -118,9 +118,6 @@ func (i *LoadBalancerDiscovery) refresh(ctx context.Context) ([]*targetgroup.Gro
 
 	// Fetch all floating IPs
 	fipPages, err := floatingips.List(networkClient, floatingips.ListOpts{}).AllPages(ctx)
-	if err != nil {
-		return nil, fmt.Errorf("failed to list all fips: %w", err)
-	}
 	if err != nil {
 		return nil, fmt.Errorf("failed to list floating IPs: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,6 @@ func (i LoadBalancerDiscovery) refresh(ctx context.Context) ([]targetgroup.Gro`
`118`	`118`
`119`	`119`	`// Fetch all floating IPs`
`120`	`120`	`fipPages, err := floatingips.List(networkClient, floatingips.ListOpts{}).AllPages(ctx)`
`121`		`- if err != nil {`
`122`		`- return nil, fmt.Errorf("failed to list all fips: %w", err)`
`123`		`- }`
`124`	`121`	`if err != nil {`
`125`	`122`	`return nil, fmt.Errorf("failed to list floating IPs: %w", err)`
`126`	`123`	`}`