fix: add missing closing brace in circom template when gen_substrs=false #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

VolodymyrBg wants to merge 1 commit into zkemail:main from VolodymyrBg:fix/circom-template-closing-brace

VolodymyrBg commented Aug 25, 2025

Problem

gen_circom_template was missing closing brace } when gen_substrs=false,
generating invalid circom files for CLI commands.

Root Cause

gen_circom_allstr() doesn't include closing brace
add_substrs_constraints() adds the closing brace
When gen_substrs=false, only gen_circom_allstr() output was written

Solution

Added else block to write closing brace } when substrings are not generated.

Impact

Fixes CLI commands with gen_substrs=false
No impact on existing functionality
All generated circom files now have valid syntax


          fix: add missing closing brace in circom template when gen_substrs=false

e1f7478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet