Skip to content

Commit 1356681

Browse files
authored
Little less overhead when trace/debug logging is disabled (#1415)
Signed-off-by: Jörg Sautter <[email protected]>
1 parent 9f315fb commit 1356681

File tree

1 file changed

+7
-3
lines changed
  • com.zsmartsystems.zigbee.dongle.ember/src/main/java/com/zsmartsystems/zigbee/dongle/ember/internal/ash

1 file changed

+7
-3
lines changed

com.zsmartsystems.zigbee.dongle.ember/src/main/java/com/zsmartsystems/zigbee/dongle/ember/internal/ash/AshFrameHandler.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,9 @@ private int[] getPacket() throws IOException {
189189

190190
while (!closeHandler) {
191191
int val = port.read();
192-
logger.trace("ASH RX: {}", String.format("%02X", val));
192+
if (logger.isTraceEnabled()) {
193+
logger.trace("ASH RX: {}", String.format("%02X", val));
194+
}
193195
switch (val) {
194196
case ASH_CANCEL_BYTE:
195197
// Cancel Byte: Terminates a frame in progress. A Cancel Byte causes all data received since the
@@ -273,15 +275,17 @@ public void run() {
273275
final AshFrame packet = AshFrame.createFromInput(packetData);
274276
AshFrame responseFrame = null;
275277
if (packet == null) {
276-
logger.debug("<-- RX ASH error: BAD PACKET {}", frameToString(packetData));
278+
if (logger.isDebugEnabled()) {
279+
logger.debug("<-- RX ASH error: BAD PACKET {}", frameToString(packetData));
280+
}
277281

278282
// Send a NAK and set rejection condition
279283
if (!rejectionCondition) {
280284
rejectionCondition = true;
281285
responseFrame = new AshFrameNak(ackNum);
282286
}
283287
} else {
284-
logger.debug("<-- RX ASH frame: {}", packet.toString());
288+
logger.debug("<-- RX ASH frame: {}", packet);
285289

286290
// Reset the exception counter
287291
exceptionCnt = 0;

0 commit comments

Comments
 (0)