Skip to content

Commit 90a7774

Browse files
packageInfo: unnecessary test removal
removed non-fallback case for app bundleId as is already covered under store_test file removed unnecessary helper function setPackageInfo
1 parent ce275ab commit 90a7774

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

test/model/binding.dart

+1-4
Original file line numberDiff line numberDiff line change
@@ -236,14 +236,11 @@ class TestZulipBinding extends ZulipBinding {
236236
}
237237

238238
@override
239-
Future<PackageInfo?> get packageInfo async => packageInfoResult;
239+
Future<PackageInfo> get packageInfo async => packageInfoResult?? _defaultPackageInfo;
240240

241241
@override
242242
PackageInfo? get syncPackageInfo => packageInfoResult;
243243

244-
void setPackageInfo(PackageInfo? packageInfo){
245-
packageInfoResult= packageInfo;
246-
}
247244

248245
void _resetFirebase() {
249246
_firebaseInitialized = false;

test/notifications/receive_test.dart

+2-7
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,15 @@ void main() {
3232
});
3333

3434
group('tokens', () {
35-
test('APNs token registration using correct app bundle ID', () async {
36-
await init();
37-
check((await testBinding.packageInfo)?.packageName)
38-
.equals('com.zulip.flutter.test');
39-
}, );
4035

4136
test('Fallback to default appBundleId if packageInfo is null', () async {
4237
await init();
4338
// setting package Info to null
44-
testBinding.setPackageInfo(null);
39+
testBinding.packageInfoResult=null;
4540

4641
const defaultAppId = 'com.zulip.flutter.test';
4742

48-
check((await testBinding.packageInfo)?.packageName?? defaultAppId)
43+
check((await testBinding.packageInfo).packageName)
4944
.equals(defaultAppId);
5045
}, );
5146
});

0 commit comments

Comments
 (0)