Add comments

Author: JonathanMagnan

src/EntityFramework.DynamicFilters.Shared/LambdaToDbExpressionVisitor.cs

@@ -80,7 +80,12 @@ private LambdaToDbExpressionVisitor(DynamicFilterDefinition filter, DbExpression
 
         #region ExpressionVisitor Overrides
 
-        private ConstantExpression GetByteConstant(Expression expression)
+        /// <summary>
+        /// Attempts to try convert the expression into a byte. The expression must be a constant and in range of a byte.
+        /// </summary>
+        /// <param name="expression">The expression.</param>
+        /// <returns>A expression converted to byte or null if the expression was not a constant or in range of a byte.</returns>
+        private ConstantExpression TryGetByteConstant(Expression expression)
         {
             if (expression.NodeType != ExpressionType.Constant || expression.Type != typeof(int))
                 return null;
@@ -94,6 +99,9 @@ private ConstantExpression GetByteConstant(Expression expression)
             return null;
         }
 
+        /// <summary>Gets inner operand.</summary>
+        /// <param name="expression">The expression.</param>
+        /// <returns>The inner operand.</returns>
         private Expression GetInnerOperand(Expression expression)
         {
             switch (expression.NodeType) {
@@ -110,6 +118,10 @@ private Expression GetInnerOperand(Expression expression)
             }
         }
 
+        /// <summary>If possible, we try to cast both side to byte otherwise we return the current BinaryExpression.</summary>
+        /// <param name="node">The node.</param>
+        /// <remarks>Pull: https://github.com/zzzprojects/EntityFramework.DynamicFilters/pull/164 </remarks>
+        /// <returns>The BinaryExpression we try to cast both side to byte otherwise we return the current BinaryExpression.</returns>
         private BinaryExpression OptimizeByteEnumComparisons(BinaryExpression node)
         {
             if (node.Method != null)
@@ -136,12 +148,12 @@ private BinaryExpression OptimizeByteEnumComparisons(BinaryExpression node)
             if (leftIsByteEnum)
                 leftOperand = Expression.Convert(leftOperand, typeof(byte));
             else
-                leftOperand = GetByteConstant(leftOperand);
+                leftOperand = TryGetByteConstant(leftOperand);
 
             if (rightIsByteEnum)
                 rightOperand = Expression.Convert(rightOperand, typeof(byte));
             else
-                rightOperand = GetByteConstant(rightOperand);
+                rightOperand = TryGetByteConstant(rightOperand);
 
             if (leftOperand == null || rightOperand == null)
                 return node;

src/EntityFramework.DynamicFilters.sln

@@ -25,6 +25,8 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "DynamicFiltersTests.Shared"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DynamicFiltersTests.NetStandard21", "DynamicFiltersTests.NetStandard21\DynamicFiltersTests.NetStandard21.csproj", "{89FAD78B-B06F-4A31-B9C0-E521803EE0E8}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Z.Lab", "Z.Lab\Z.Lab.csproj", "{9A4EB2AB-5FDC-4947-AC90-372E43383BC3}"
+EndProject
 Global
 	GlobalSection(SharedMSBuildProjectFiles) = preSolution
 		EntityFramework.DynamicFilters.Shared\EntityFramework.DynamicFilters.Shared.projitems*{13d421cd-5dc4-4287-b1b2-110a9cb5e07f}*SharedItemsImports = 13
@@ -57,6 +59,10 @@ Global
 		{89FAD78B-B06F-4A31-B9C0-E521803EE0E8}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{89FAD78B-B06F-4A31-B9C0-E521803EE0E8}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{89FAD78B-B06F-4A31-B9C0-E521803EE0E8}.Release|Any CPU.Build.0 = Release|Any CPU
+		{9A4EB2AB-5FDC-4947-AC90-372E43383BC3}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{9A4EB2AB-5FDC-4947-AC90-372E43383BC3}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{9A4EB2AB-5FDC-4947-AC90-372E43383BC3}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{9A4EB2AB-5FDC-4947-AC90-372E43383BC3}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE