Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize new partner rather than run whole process #264

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Draft

Randomize new partner rather than run whole process #264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
904a3df
loop until new partner is different
kanin-kearpimy Mar 12, 2024
144c9af
add comment
kanin-kearpimy Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/model/model.class.ts
View file
Original file line number Diff line number Diff line change
@@ -283,11 +283,14 @@ export class Model {
return this.mutatePermutation();
}

const partner = min + 1 == max ? min : Paul.chooseBetween(max, min, BIAS.REVERSE_BELL);
if (chosen == partner) {
// would that ever happen ?
return this.mutatePermutation();
let partner = min + 1 == max ? min : Paul.chooseBetween(max, min, BIAS.REVERSE_BELL);
while (chosen == partner) {
// if chosen is same as partner
// randomize until it isn't
// this will work on condition: there are more than two choices in range.
partner = Paul.chooseBetween(max, min, BIAS.REVERSE_BELL);
}

const [a] = Model._order.splice(chosen, 1);

const b = Model._order[partner];

Unchanged files with check annotations Beta

View file
src/registerAllocator/RegisterAllocator.class.ts
* limitations under the License.
*/
import { uniq } from "lodash-es";

Check warning on line 17 in src/registerAllocator/RegisterAllocator.class.ts

GitHub Actions / TS Lint check 

Run autofix to sort these imports!
import {
AllocationFlags,
View file
test/redZone.ts
* limitations under the License.
*/
import { basename } from "path";

Check warning on line 17 in test/redZone.ts

GitHub Actions / TS Lint check 

Run autofix to sort these imports!

Check warning on line 17 in test/redZone.ts

GitHub Actions / TS Lint check 

'path' imported multiple times
import { afterAll, expect, it, describe, vi } from "vitest";
import { readFileSync, readdirSync, existsSync } from "fs";
import { resolve as pathResolve } from "path";

Check warning on line 20 in test/redZone.ts

GitHub Actions / TS Lint check 

'path' imported multiple times
import { Optimizer } from "@/optimizer";