Centralize wallet selector#728
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes the wallet selector logic to handle both redirect and non-redirect sign-up cases. Key changes include replacing the onExistingWallets/onExistingWalletsWithTarget callbacks with a unified WalletSelectionUiHandler, adding new properties (target and isRedirect) to AuthCodePkceSignupArgs, and exposing wallet selector registration functions in the Wallets and Manager classes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/wallet/wdk/src/sequence/wallets.ts | Added WalletSelectionUiHandler support, new signup args properties, and methods to register/unregister wallet selectors |
| packages/wallet/wdk/src/sequence/types/wallet.ts | Defined new types for wallet selector options, context, and result |
| packages/wallet/wdk/src/sequence/manager.ts | Forwarded wallet selector registration/unregistration functions to the Wallets module |
Comments suppressed due to low confidence (1)
packages/wallet/wdk/src/sequence/wallets.ts:47
- [nitpick] The new 'target' property in AuthCodePkceSignupArgs might benefit from a more descriptive name (e.g., 'redirectTarget') to clarify its purpose for developers reading the code.
target: string
corbanbrook
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralized wallet selectors handles both redirect and non-redirect cases