-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic for block style entry points #390
Add logic for block style entry points #390
Conversation
🦋 Changeset detectedLatest commit: 2c116e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-block-specific-CSS
@dmtrmrv Would you mind try adding a few e2e tests? You can follow the structure of the existing e2e tests, essentially you can create a new "project" with an expected block structure, run tooklit via jest then asset that toolkit is compiling the right files. |
…-block-specific-CSS
…-block-specific-CSS
…c-CSS' of github.com:10up/10up-toolkit into feature/339-filename-based-entrypoint-for-block-specific-CSS
Related Issue/RFC: #339
This PR introduces several enhancements and fixes to the configuration and entry logic for the toolkit package. Key changes include the reorganization of path configurations, the addition of a new configuration option for loading block-specific styles, and the update of the webpack entry to support this new feature.
Changes
Path Configuration Updates (
paths.config.js
):blocksStyles
.Webpack Entry Updates (
entry.js
):loadBlockSpecificStyles
to conditionally load CSS files specific to blocks.assets/css/blocks
directory.Default Configuration Update (
config.js
):loadBlockSpecificStyles
option to the default configuration, with a default value set tofalse
.Requires this to be deployed to Scaffold: 10up/wp-scaffold#229
Checklist: