Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/676: ensure all WP_CLI commands work #682

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix/676: ensure all WP_CLI commands work #682

merged 3 commits into from
Feb 5, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Feb 2, 2024

Description of the Change

This PR adds fixes for WP_CLI commands that are breaking after changes in PR #611
Closes #676

How to test the Change

Test the following commands:

  • post
  • text
  • text_to_speech
  • transcribe_audio
  • generate_excerpt
  • image
  • crop
  • embeddings

Changelog Entry

Not needed as the feature is broken in PR #611

Credits

Props @dkotter @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested review from dkotter, jeffpaul and a team as code owners February 2, 2024 12:30
@Sidsector9 Sidsector9 self-assigned this Feb 2, 2024
@@ -956,6 +956,10 @@ public function has_access(): bool {
$access = ( ! in_array( static::ID, $opted_out_features, true ) );
}

if ( defined( 'WP_CLI' ) && WP_CLI ) {
$access = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkotter can you verify this. I've added it so that a feature can run via WP_CLI.
cc: @iamdharmesh

@jeffpaul jeffpaul added this to the 3.0.0 milestone Feb 2, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 5, 2024
@dkotter dkotter merged commit 3b7262a into develop Feb 5, 2024
13 checks passed
@dkotter dkotter deleted the fix/676 branch February 5, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all WP-CLI commands work
3 participants