-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Key Takeaways Feature #843
Conversation
Solid work on a Friday!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @dkotter! This looks amazing. I’ve added two minor optional comments, but everything looks good to me.
src/js/settings/components/feature-additional-settings/key-takeaways.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Dharmesh Patel <[email protected]>
Note the E2E tests on WP Trunk have a few failures related to our |
BTW I love the |
Description of the Change
This PR adds in a new Feature, called Key Takeaways, that when enabled and configured, introduces a new Key Takeaways block.
This block can only be added once per post and when inserted, will send a request off to the configured Provider to generate the key takeaways of the content and render those as either bullets or paragraphs, depending on the setting in the block. This can be toggled back and forth after the key takeaways have been generated. The key takeaways can also be edited inline or removed.
It also renders a title for this block (defaults to Key Takeaways) that can be edited or deleted altogether. And we have a Refresh button in the sidebar settings for the block, allowing you to regenerated the key takeaways at any point.
Closes #505
Screenshots
How to test the Change
Changelog Entry
Credits
Props @dkotter, @jeffpaul
Checklist: