Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gutenberg deprecation warnings #860

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 28, 2025

Description of the Change

As of the last release our minimum supported version of WordPress is 6.6. There were quite a few deprecation warnings added in that version that we've previously been ignoring but we can now safely update those to the proper components to fix those.

In addition, while fixing those up and testing to ensure everything worked, found a few other things I thought worth fixing:

  • In both our title generation and excerpt generation Features, we grab the content and/or title of the item to send along. But we grab this on page load so if someone were to update the content and then click the button, the most recent version of the content isn't used. This has been fixed
  • Took some learnings from Add new Content Generation Feature #859 to make the modal we show when generating titles a bit nicer. It's now wider and if generating multiple titles, those end up in columns instead of stacked

Before

Generate title modal before changes

After

Generate title modal after changes

How to test the Change

Minimal changes made across multiple Features so ideal is to test to ensure those Features still work and no WordPress 6.5 or 6.6 deprecation warnings are shown. Note there are some deprecation notices introduced in 6.7 around bottom margin styles being deprecated since version 6.7 and will be removed in version 7.0 but decided not to address those yet

Changelog Entry

Changed - Update the layout of the generate titles modal
Fixed - Fix various Gutenberg deprecation notices added in WordPress 6.5 and 6.6
Fixed - Ensure we pass the most recent version of the content in our title and excerpt generation Features

Credits

Props @dkotter

Checklist:

…individual title better spaced. Also add a hidden label to each for better accessibility
…erating a title or excerpt, if the content had changed, we weren't using the most recent version
@dkotter dkotter added this to the 3.4.0 milestone Feb 28, 2025
@dkotter dkotter self-assigned this Feb 28, 2025
@dkotter dkotter requested review from jeffpaul and a team as code owners February 28, 2025 22:05
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 28, 2025
@dkotter dkotter requested review from iamdharmesh and removed request for a team and jeffpaul March 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Status: Code Review
Development

Successfully merging this pull request may close these issues.

1 participant