Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP Plugin - PHPCS - Manual fixes #689

Merged
merged 18 commits into from
Feb 29, 2024
Merged

WP Plugin - PHPCS - Manual fixes #689

merged 18 commits into from
Feb 29, 2024

Conversation

claytoncollie
Copy link
Contributor

@claytoncollie claytoncollie commented Jan 29, 2024 •
edited
Loading

Description of the Change

Requires #688

These are the manual fixes for the WP plugin.

Part 2 for addressing #625

Changelog Entry

Changed - Address PHP coding standards manual fixes

Credits

Props @claytoncollie

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2549ba8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 6:22pm

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@claytoncollie claytoncollie mentioned this pull request Feb 15, 2024
Closed
@claytoncollie claytoncollie mentioned this pull request Feb 15, 2024
Merged
@claytoncollie claytoncollie marked this pull request as ready for review February 15, 2024 21:07
@claytoncollie claytoncollie mentioned this pull request Feb 15, 2024
Open
1 task
nicholasio
nicholasio requested changes Feb 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio
WP Plugin - PHPCS - Force short array syntax (#696)
2549ba8 
### Description of the Change
Automatic linting PR to enforce short array syntax.

Require #689 

Part 3 for addressing #625

### Changelog Entry
> Changed - Enforce short array syntax

### Credits
Props @claytoncollie
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio nicholasio merged commit ae4315f into feature/wp-phpcs-3 Feb 29, 2024
11 checks passed
@nicholasio nicholasio deleted the feature/wp-phpcs-3-manual-fixes branch February 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasio nicholasio nicholasio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claytoncollie @nicholasio