Merged
Conversation
Contributor
Author
|
Oh this is ready also btw, with the threaded model thingy this seems to perform nicely even with lots of boats for example at salvaging points The only problem is the sails now conflict with the detail distance exception they have |
aHooder
approved these changes
Feb 28, 2026
Member
aHooder
left a comment
aHooder
left a comment
There was a problem hiding this comment.
I'll merge this, but just leaving a note regarding performance 🙂
| "undoVanillaShading": false | ||
| }, | ||
| { | ||
| "description": "Sail Med Tier", |
Member
There was a problem hiding this comment.
Not a blocker, but it would be better for performance to add two model overrides instead of distinguishing between them via color overrides, since each color override check has to be processed for every triangle, instead of once for the whole model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animated stuff, draft till performance is solved