update described_class to speific class#12862
Open
shilenpatel1 wants to merge 3 commits into
Open
Conversation
shilenpatel1
force-pushed
the
438_remove_described_class
branch
3 times, most recently
from
4bf6a06 to
871f82d
Compare
Contributor
|
I'm not sure if we should update specs that don't apply to the reporting-related code. Let's check with @luigi |
Contributor
|
In the meantime, split the work into two commits, one commit for the reporting specs and another one for everything else. That way we can pick and choose what we merge |
shilenpatel1
force-pushed
the
438_remove_described_class
branch
from
871f82d to
287ec19
Compare
* changelog: Internal, Reporting, replace described_class in reporting see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/438
shilenpatel1
force-pushed
the
438_remove_described_class
branch
from
287ec19 to
cfa71da
Compare
* changelog: Internal, Reporting, lint fix see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/438
* changelog: Internal, Reporting, replace described_class in non-reporting see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Reporting, update described_class
see https://gitlab.login.gov/lg-teams/Team-Data/reporting/-/issues/438