Update phonelib#13119
Open
mdiarra3 wants to merge 4 commits into
Open
Conversation
monfresh
reviewed
May 18, 2026
| 'GB' => ['7700900123', '***** **0123'], | ||
| 'DE' => ['15123456789', '***** ***6789'], | ||
| 'IN' => ['9123456789', '****** *6789'], | ||
| 'BR' => ['11987654321', '(**) *****-4321'], |
Contributor
There was a problem hiding this comment.
It looks like for most of these, there is an extra asterisk. For example, 9123456789 has 10 digits, but ****** *6789 has 11 characters. I would think the total characters would match on both sides, no?
monfresh
approved these changes
May 20, 2026
Contributor
monfresh
left a comment
monfresh
left a comment
There was a problem hiding this comment.
LGTM. Maybe at some point we might refactor this into a class with well-named private methods to make it easier to understand the different processing that's happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.