feat: Create and delete runtime environments, and add task logs.#13081
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeab4b64f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| createTask.AddSubTask(task.GetTaskName(create.Name, task.TaskCreate, task.TaskScopeRuntime), func(t *task.Task) error { | ||
| return executeRuntimeCreateTask(create, runtime, app, appDetail, appVersionDir, t) | ||
| }, nil) |
There was a problem hiding this comment.
When a PHP runtime build or extension installation takes longer than the task package's default 30-minute subtask timeout, this wrapper reports the create task as failed with a timeout even though buildRuntimeWithResult can still be running under its own 60-minute build/install timeouts and may later mark the runtime running. Use AddSubTaskWithOps with a timeout at least as long as the build path (or no timeout) for runtime creation so slow but valid builds don't show failed task logs.
Useful? React with 👍 / 👎.
2 participants
Refs #10494