-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle empty parentheses in expression tree building #3449
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ff91b5f
to
4268af5
Compare
|
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by Nikita Fedkin
Fixes BSL-LANGUAGE-SERVER-87
This commit addresses an issue where the
ExpressionTreeBuildingVisitor
would throw an exception when encountering empty parentheses in an expression, such as in anIf
statement. The changes include:RPAREN
tokens in thevisitPrimary
method to handle closing parentheses.If
statement with empty parentheses.If you have any questions or feedback for the Sentry team about this fix, please email [email protected] with the Run ID: 10353.