Skip to content

Fix overflow issue inside MobileMenu #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alecherryy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix overflow issue inside MobileMenu #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38dc4ca
change overflow-hidden property
alecherryy May 22, 2026
9d386ce
fix overflow issue inside mobile menu
alecherryy May 22, 2026
2b4e1da
rempve unused imports
alecherryy May 22, 2026
3a3ab57
clean up classes
alecherryy May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/shared/layouts/header/components/menu/desktop-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import Link from 'next/link'
import { useState } from 'react'
import { MenuProps } from './menu'
import { usePathname } from 'next/navigation'
import classNames from 'classnames'
import Image from 'next/image'
import { ExternalLink } from 'lucide-react'

export const DesktopMenu = ({
Expand Down
2 changes: 1 addition & 1 deletion components/shared/layouts/header/components/menu/mobile-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ const MenuIcon = ({
isOpen: boolean
}) => {
return (
<div className="relative z-[5]">
<div className="relative z-5">
<button
className="bg-black rounded-full h-10 w-10 border-none cursor-pointer flex items-center justify-center"
onClick={handleClick}
Expand Down
3 changes: 2 additions & 1 deletion components/shared/layouts/header/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Container } from 'components/shared/layouts/container/container'
import debounce from 'lodash/debounce'
import { useEffect, useRef, useState } from 'react'
import { Logo } from './components/logo/logo'
import classNames from 'classnames'
import { SanityImage } from 'types/image'
import { InternalOrExternalLink } from 'types/link'
import { resolveInternalOrExternalLink } from 'utils/link'
Expand Down Expand Up @@ -54,6 +53,7 @@ export const Header = ({ logo, items, donate }: Props) => {
div.style.transition = 'none'
div.style.boxShadow = 'none'
div.style.background = 'transparent'
div.style.overflow = 'hidden'
setIsSticky(false)
}
// set isSticky to true if the user has scrolled more than 80px
Expand All @@ -63,6 +63,7 @@ export const Header = ({ logo, items, donate }: Props) => {
div.style.position = 'fixed'
div.style.transform = 'translateY(-100%)'
div.style.background = '#fff'
div.style.overflow = 'visible'

setTimeout(() => {
div.style.transition = 'all 0.4s cubic-bezier(0.83, 0, 0.17, 1)'
Expand Down