Address CodeRabbit feedback on #47/#57 (a11y caption + doc fixes) - #64
Conversation
Post-merge review comments (both PRs merged while CodeRabbit was rate-limited), verified still-valid against main: - a11y (#47): DiagramRenderer.attachmentString(diagram:title:) rendered the title caption visually but narrated only the diagram — assistive-tech users lost the caption. Fold a non-empty title into the altText. New test testCaptionIsNarrated asserts the caption leads the narration (and no stray prefix when title is nil). - README (#47): document the format-aware pngData(source:format:theme:) overload in both API lists (it shipped in #47 but was omitted). - BRIEF.md (#57): toolchain floor said Swift 6 / Xcode 16+; the rest of the docs say Swift 6.2 / Xcode 26. Aligned. - pi-canvas README (#57): "rendered once (cached)" contradicted the next sentence ("zooming re-rasterizes"); clarify "once per zoom level". 417 tests pass (+1). Docs + one small a11y fix; no behavior change to rendering. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CJYAapHgDn2PWGNABnFtv
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThe parsed-diagram attachment path now includes non-empty titles in accessibility narration. Tests cover titled and untitled attachments. Documentation lists the format-aware PNG entry point and updates platform and canvas details. ChangesRendering and documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…pot) The doc-accuracy audit (Batch 1, #57) corrected the "Platforms:" bullet and the "Apple platforms only today" caveat but missed the opening definition, which still said MermaidKit "renders … natively on Apple platforms — pure Swift and CoreGraphics" (the line wrapped across "natively on" / "Apple platforms", so the audit's grep didn't catch it). Reword to the multi-platform reality (CoreGraphics on Apple + Android/Windows/WASM/Flutter over the shared layout core) and add SVG to the output list, matching the rest of the file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CJYAapHgDn2PWGNABnFtv
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
CodeRabbit posted actionable comments on #47 and #57 after they merged (it was rate-limited at merge time). All verified still-valid against
mainand fixed, plus one related audit blind spot I caught while reviewing:DiagramRenderer.attachmentString(diagram:title:)rendered thetitlecaption visually but narrated onlydescribe(diagram), so screen-reader users lost the caption. Now folds a non-empty title into the altText. New testtestCaptionIsNarratedlocks it.pngData(source:format:theme:)overload in both API lists.417 tests (+1). One small a11y fix + docs; no rendering behavior change.
🤖 Generated with Claude Code