Skip to content

Try defining volumes and volume mounts as dict #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sunu
Copy link
Contributor

@sunu sunu commented May 23, 2025

Trying out suggestions from #6010 (comment)

Haven't tried this out live yet, because I'm having some trouble logging in to the MAAP staging hub.

But if I understand correctly, we will run into issues without upstream changes because of how extraFiles is handled. This expects the KubeSpawner.volumes and KubeSpawner.volume_mounts to be lists. Similarly extraVolumes / extraVolumeMounts handling also expects KubeSpawner.volumes and KubeSpawner.volume_mounts to be lists.

I have tried this out on MAAP staging and it seems to work as expected.

Copy link

github-actions bot commented May 23, 2025

Merging this PR will trigger the following deployment actions.

Support deployments

No support upgrades will be triggered

Staging deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws maap staging Following helm chart values files were modified: staging.values.yaml

Production deployments

No production hub upgrades will be triggered

@sunu sunu force-pushed the maap-staging-group-shared-directories-2 branch 2 times, most recently from e218550 to 25eae5a Compare May 27, 2025 11:45
@sunu sunu marked this pull request as ready for review May 27, 2025 11:52
@sunu sunu requested a review from yuvipanda May 27, 2025 11:52
# so that the user can't see the contents of other groups' folders
# that the user is not a member of
name: shared-group-placeholder
mountPath: /home/jovyan/shared-group
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this the best approach to fix visibility of stale group shared folders. Please let me know if there's a better way to do this.

The concern is: If a user previously had a shared group folder mounted (e.g., to /home/jovyan/shared-group/<group-folder>), their underlying home PVC (<home-pvc>/<user>/) might now contain a persistent directory at shared-group/<group-folder> that was created by Kubernetes as a mount point.

Later, if the user is no longer in that group, the specific mount for the actual shared data is removed. However, the shared-group/<group-folder> directory within their personal PVC home will still be visible (as part of the main /home/jovyan mount). This can lead to confusion, showing outdated or empty folders for groups they no longer have access to.

@sunu sunu force-pushed the maap-staging-group-shared-directories-2 branch from 74a6779 to e008806 Compare May 29, 2025 07:09
@sunu
Copy link
Contributor Author

sunu commented May 29, 2025

The test is failing because the jupyterhub chart expects singleuser.storage to be defined as an object but we are intentionally setting it to null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant