-
Notifications
You must be signed in to change notification settings - Fork 74
Try defining volumes and volume mounts as dict #6102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deploymentsNo production hub upgrades will be triggered |
e218550
to
25eae5a
Compare
# so that the user can't see the contents of other groups' folders | ||
# that the user is not a member of | ||
name: shared-group-placeholder | ||
mountPath: /home/jovyan/shared-group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this the best approach to fix visibility of stale group shared folders. Please let me know if there's a better way to do this.
The concern is: If a user previously had a shared group folder mounted (e.g., to /home/jovyan/shared-group/<group-folder>
), their underlying home PVC (<home-pvc>/<user>/)
might now contain a persistent directory at shared-group/<group-folder>
that was created by Kubernetes as a mount point.
Later, if the user is no longer in that group, the specific mount for the actual shared data is removed. However, the shared-group/<group-folder>
directory within their personal PVC home will still be visible (as part of the main /home/jovyan
mount). This can lead to confusion, showing outdated or empty folders for groups they no longer have access to.
74a6779
to
e008806
Compare
The test is failing because the jupyterhub chart expects |
Trying out suggestions from #6010 (comment)
Haven't tried this out live yet, because I'm having some trouble logging in to the MAAP staging hub.But if I understand correctly, we will run into issues without upstream changes because of howextraFiles
is handled. This expects theKubeSpawner.volumes
andKubeSpawner.volume_mounts
to be lists. SimilarlyextraVolumes
/extraVolumeMounts
handling also expectsKubeSpawner.volumes
andKubeSpawner.volume_mounts
to be lists.I have tried this out on MAAP staging and it seems to work as expected.