Fix have_negative() using correct constraint attributes#122
Closed
VaibhavSurolia wants to merge 1 commit into52North:mainfrom
Closed
Fix have_negative() using correct constraint attributes#122VaibhavSurolia wants to merge 1 commit into52North:mainfrom
VaibhavSurolia wants to merge 1 commit into52North:mainfrom
Conversation
Resolved AttributeError caused by invalid neg_size reference.
Collaborator
|
Hi @VaibhavSurolia, thank you for your PR. We appreciate the time and effort that was put into it but, unfortunately, we have to decline the PR due to the limited added value to the tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The method
have_negative()referenced a non-existent attributeneg_size, causing a runtime error, related to #118 issue.Fix
Updated the method to correctly use
neg_dis_sizeandneg_cont_size.Impact
Prevents AttributeError and ensures correct constraint detection.