Draft
Conversation
…middleware into AL/NewRedisGraphModeling
Artonus
reviewed
Apr 14, 2023
|
|
||
| public override Dto.Dto ToDto() | ||
| { | ||
| var domain = this; |
Member
There was a problem hiding this comment.
Running action has to store its placement
Artonus
reviewed
Apr 14, 2023
src/Models/Dto/ActionRunningDto.cs
Outdated
| [RedisIdField] | ||
| public override string Id { get; set; } = default!; | ||
| [Indexed] | ||
| public string ActionParentId { get; init; } = default!; // This is the ID in which the actionRunning us based from the normal Action |
Artonus
reviewed
Apr 14, 2023
src/Models/Dto/ActionRunningDto.cs
Outdated
| return new ActionRunningModel() | ||
| { | ||
| Id = Guid.Parse(dto.Id.Replace(Prefix, "")), | ||
| ActionParentId = Guid.Parse(dto.ActionParentId.Replace(Prefix, "")), |
Member
There was a problem hiding this comment.
We don't have to replace prefixes in these fields
Artonus
reviewed
Apr 14, 2023
| //Add the actionRunning to redis | ||
| foreach (ActionModel action in task.ActionSequence) | ||
| { | ||
| ActionRunningModel actionRunningTemp = new ActionRunningModel(); |
Member
There was a problem hiding this comment.
Needs to be extracted into a separate method
Artonus
reviewed
Apr 14, 2023
| /// <inheritdoc/> | ||
| public async Task<bool> DeletePlanAsync(ActionPlanModel actionPlan) | ||
| { | ||
| // Delete OWNS relationship between robot and actionPlan |
Member
There was a problem hiding this comment.
Extract to the separate methods
Artonus
reviewed
Apr 14, 2023
| return await ContainerImageGetForInstanceAsync(id, CancellationToken.None); | ||
| } | ||
|
|
||
| public async Task<bool> ActionRunningAddAsync(ActionRunningModel actionRunning) |
Member
There was a problem hiding this comment.
The functions have to be implemented
Artonus
reviewed
Apr 14, 2023
| return Ok(resourcePlan); | ||
|
|
||
| await _redisInterfaceClient.AddRelationAsync(robot2, resourcePlan, "OWNS"); | ||
| await _redisInterfaceClient.AddRelationAsync(robot2, resourcePlan, "WANTS_TO_RUN"); |
Member
There was a problem hiding this comment.
Doesn't a robot still OWN an action plan?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.