-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add LC-S3-WIFI-1.54TFT开发板 #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
这个板子的支持有后续了吗 |
ChiruMori
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参考其他同类 PR,似乎需要提供一个关于板子的自述文件
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起来针对这个文件的修改应该取消
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 已恢复误修改的文件。
- 已添加 lc-s3-wifi-1.54tft 板卡的 README.md。
PR 已准备好供 review。
| // .text_font = &font_puhui_20_4, | ||
| // .icon_font = &font_awesome_20_4, | ||
| // .emoji_font = font_emoji_64_init(), | ||
| // }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释掉的代码可以去掉
| }; | ||
| gpio_config(&io_conf); // 应用配置 | ||
| gpio_set_level(RELAY_LED,0); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} 后面需要一个空行。
| // thing_manager.AddThing(iot::CreateThing("Speaker")); | ||
| // thing_manager.AddThing(iot::CreateThing("Screen")); | ||
| // thing_manager.AddThing(iot::CreateThing("Battery")); | ||
| // thing_manager.AddThing(iot::CreateThing("Relay")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些注释掉的可以去掉
| set(BUILTIN_ICON_FONT font_awesome_30_4) | ||
| set(DEFAULT_EMOJI_COLLECTION twemoji_64) | ||
| elseif(CONFIG_BOARD_TYPE_LC_S3_WIFI_1_54TFT) | ||
| set(BOARD_TYPE "lc-s3-wifi-1.54tft") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个板子不需要配置字体和表情吗?
Summary
This PR adds configuration support for the LC-S3-WIFI-1.54TFT development board.
本次 PR 新增对 LC-S3-WIFI-1.54TFT 开发板 的板级配置支持。
Details
main/boards/lc-s3-wifi-1.54tft/在
main/boards/lc-s3-wifi-1.54tft/中新增板卡配置文件CMakeLists.txtandKconfig.projbuildto include the new board更新
CMakeLists.txt和Kconfig.projbuild文件以支持该新板Attachments
Below are reference images for the board and its wiring diagram.
以下为该板卡实物图和接线示意图: