Skip to content

Conversation

@jpiat
Copy link

@jpiat jpiat commented Nov 17, 2025

Added support for Link as HU-087 boards. This board is very cheap and while the USB connector is not connected to the ESP32-S3 USB lanes, there is a programing header under the battery.

@78
Copy link
Owner

78 commented Nov 17, 2025

It's better not to use a board name starting with esp32-s3, but rather to use a noticeable prefix like a company or product name.

@jpiat
Copy link
Author

jpiat commented Nov 17, 2025

should i just remove the esp32-s3 prefix ? I am having a hard time finding who the manufacturer is since its sold by multiple seller on Aliexpress. Seems to be 1XAI but i'm not sure.

"builds": [
{
"name": "esp32s3-hu087",
"name": "hu087",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be hu-087, or it could be errors if you initialize the compilation with python scripts/release.py [build_name].

@@ -0,0 +1,7 @@

[product](https://fr.aliexpress.com/item/1005010207331462.html?spm=a2g0o.productlist.main.1.2852731dDubQiX&algo_pvid=228f3b8e-93f4-4e53-8536-2dc3bfe319a0&algo_exp_id=228f3b8e-93f4-4e53-8536-2dc3bfe319a0-0&pdp_ext_f=%7B%22order%22%3A%2213%22%2C%22eval%22%3A%221%22%2C%22fromPage%22%3A%22search%22%7D&pdp_npi=6%40dis%21EUR%2123.37%2113.79%21%21%21188.32%21111.12%21%402103835c17633264955994954e51d4%2112000051520233591%21sea%21FR%21930595778%21X%211%210%21n_tag%3A-29919%3Bd%3A4ecad613%3Bm03_new_user%3A-29895&curPageLogUid=HBcFJJuiAYg4&utparam-url=scene%3Asearch%7Cquery_from%3A%7Cx_object_id%3A1005010207331462%7C_p_origin_prod%3A)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the query strings after ? in the URL. They're the parameters used for tracking the user.



touch_button_.OnLongPress([this]()
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The { should not be in a new line according to the Google C++ Code Style.

@jpiat jpiat requested a review from 78 November 24, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants