Refactor a few APIs. #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_789073073
branch
from
3292265 to
c668606
Compare
copybara-service
bot
force-pushed
the
test_789073073
branch
from
c668606 to
bf057af
Compare
Notably this removes the `rng` argument from `JaxTrainer` to avoid implicitly passing it. Reverts changelist 793734230 PiperOrigin-RevId: 789073073
copybara-service
bot
force-pushed
the
test_789073073
branch
from
bf057af to
dd5500f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor a few APIs.
Notably this removes the
rngargument fromJaxTrainerto avoid implicitly passing it.Reverts changelist 793734230