-
Notifications
You must be signed in to change notification settings - Fork 418
Recipe Modularization, DAG Integration, and BigQuery Integration #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0884443
to
9de3e78
Compare
|
||
|
||
def handle_cmd_args(cluster_config: XpkClusterConfig, *actions: str, **kwargs) -> bool: | ||
def handle_cmd_args(cluster_config: XpkClusterConfig, is_delete: bool, user: str, **kwargs) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the original recipe could only accept the --delete flag, this section had to be modified to allow it to accept multiple flags.
default=[2], | ||
help='List of number of slices.') | ||
|
||
# BigQuery configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for BQ PR to be merged
parser_utils.add_arguments(parser) | ||
args = parser.parse_args() | ||
|
||
if len(sys.argv) > 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is implemented to determine whether multiple flags are being used.
selected_model_names: list[str] = dataclasses.field(default_factory=lambda: ["llama3_1_8b_8192"]) | ||
num_slices_list: list[int] = dataclasses.field(default_factory=lambda: [2]) | ||
|
||
# BigQuery configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for BQ PR to be merged
Description
When integrating Recipe Modularization, DAG Integration, and BigQuery, the DAG will pass in a command that includes multiple command-line flags.
Tests
Users can use commands similar to the following to run tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-review
label.