Skip to content

Conversation

khatwanimohit
Copy link
Collaborator

@khatwanimohit khatwanimohit commented Oct 21, 2025

Description

  • Upgrade maxtext's requirements for TPUs and GPUs
  • Adds tokamax as a dependency

Note that this PR only updates the files used for installing maxtext page and stable docker images. stable-stack mode of building docker images still pins jax=0.7.0, we will remove that pin after new base image is released.

To update requirements file see instructions here

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Tested locally using uv pip install -e .[tpu] --resolution=lowest and bash setup.sh

tested that bash docker_build_dependency_image.sh MODE=nightly installs jax=0.8.1.dev20251022

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just one comment

@khatwanimohit khatwanimohit force-pushed the mohit/upgrade-maxtext branch 7 times, most recently from 09f4d9b to 9a01b04 Compare October 22, 2025 18:45
Copy link
Collaborator

@parambole parambole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the changes LGTM. I have left a non-blocking question.

Thanks!

@copybara-service copybara-service bot merged commit dbbe011 into main Oct 22, 2025
35 of 36 checks passed
@copybara-service copybara-service bot deleted the mohit/upgrade-maxtext branch October 22, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants