Modernize code related to Surfaces and the SurfaceManager

[jmcarcell]

BEGINRELEASENOTES

• Modernize code related to Surfaces and the SurfaceManager. Simplify for loops, define default destructors with =default, pass arguments by const reference when possible
• Make DetectorSurfaces not inherit from DetElement since it is not used nor needed

ENDRELEASENOTES

[github-actions]

Test Results

   18 files     18 suites   7h 13m 17s ⏱️
  372 tests   372 ✅ 0 💤 0 ❌
3 278 runs  3 278 ✅ 0 💤 0 ❌

Results for commit 0a50df9.

♻️ This comment has been updated with latest results.

[andresailer]

Hi @MarkusFrankATcernch

Could you have a look at these changes? Any reason things were the way they were and shouldn't be changed?

[MarkusFrankATcernch]

@andresailer
Short answer:no idea, Frank should know ;-)

Longer answer:
I do not know why DetectorSurfaces have to be a DetElement. I think this is the main question.
If this is-a-relagtionship is not mandatory, then the changes of Juan are all correct.
If DetectorSurfaces have to be a DetElement then not.
The fact that all DD4hep and ILC tests work is a hint that this inheritance is not necessary.

@gaede : do you remember why this relationship was introduced?

[jmcarcell]

I ran some tracking that makes use of the surfaces before and after this change and I get the same results so I'm relatively confident this is not changing anything.