Skip to content

Conversation

@jmcarcell
Copy link
Member

isValid() (a check if a collection was found in a file, because if not an empty one is returned) has been changed to hasID() in AIDASoft/podio#860. Similar to what has been done in key4hep/EDM4hep#453. In one place we can remove it since size() == 1 implies isValid() or hasID(), otherwise the size would be 0.

BEGINRELEASENOTES

  • Fix a deprecation warning in EDM4hepFileReader.cpp by changing collection.isValid() to collection.hasID().

ENDRELEASENOTES

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Test Results

   18 files     18 suites   6h 49m 1s ⏱️
  372 tests   372 ✅ 0 💤 0 ❌
3 278 runs  3 278 ✅ 0 💤 0 ❌

Results for commit 5dad64c.

♻️ This comment has been updated with latest results.

@andresailer andresailer merged commit 3bb766f into AIDASoft:master Oct 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants