feat: support for add-page and remove-page #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Title Suggestions
|
|
WalkthroughThis pull request implements comprehensive page management functionality for a website structure system. The changes add capabilities for adding new pages with automatic link integration, removing pages with proper cleanup of invalid links, and recursive deletion of page hierarchies. The implementation includes interactive user interfaces, validation systems, and proper error handling for most operations, though some critical issues exist with process termination and error handling patterns. Changes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (8)
- agents/clear/clear-generated-pages.mjs (1)
- agents/plan/user-add-page/add-links-to-pages.mjs (1)
- agents/plan/user-add-page/add-pages-to-structure.mjs (1)
- agents/plan/user-remove-page/find-pages-with-invalid-links.mjs (1)
- agents/plan/user-remove-page/remove-invalid-links-from-page.mjs (1)
- agents/plan/user-remove-page/remove-pages-from-structure.mjs (1)
- agents/plan/website-structure-tools/delete-page.mjs (3)
- types/website-structure-schema.mjs (2)
Files ignored due to filter (5)
- agents/plan/user-add-page/find-pages-to-add-links.yaml
- agents/plan/user-add-page/index.yaml
- agents/plan/user-remove-page/index.yaml
- aigne.yaml
- prompts/plan/find-pages-to-add-links.md
Review comments generated (14)
- Review: 7
- LGTM: 7
提示
与 
AIGNE CodeSmith (@codesmith) 聊天
- 回复此机器人留下的审查评论以提出后续问题。审查评论是对差异或文件的评论。
- 通过在回复中标记
@codesmith邀请机器人加入审查评论链。
代码建议
- 机器人可能会提出代码建议，但在提交前请仔细审查它们，因为行号范围可能会不对齐。
- 你可以编辑机器人做出的评论，并在建议稍有偏差时手动调整。
暂停增量审查
- 在 PR 描述中的任何位置添加
@codesmith: ignore以暂停机器人的进一步审查。
agents/plan/user-remove-page/remove-invalid-links-from-page.mjs
Outdated
Show resolved
Hide resolved
lixl39505
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for adding and removing pages from the website structure through new CLI commands add-page and remove-page. The implementation includes recursive page deletion, automatic link management, and proper translation handling for modified pages.
Key Changes:
- Added
add-pageandremove-pageCLI commands with corresponding agent workflows - Implemented recursive page deletion to handle parent-child page relationships
- Added automatic detection and cleanup of invalid internal links after page removal
- Centralized YAML stringification options to ensure consistent formatting
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
aigne.yaml |
Registers new add-page and remove-page CLI commands and agent configurations |
types/website-structure-schema.mjs |
Adds optional recursive parameter to delete page schema for cascading deletions |
agents/plan/website-structure-tools/delete-page.mjs |
Implements recursive deletion logic to remove child pages before parent |
agents/plan/user-add-page/* |
New workflow for adding pages, finding related pages, and inserting appropriate links |
agents/plan/user-remove-page/* |
New workflow for removing pages and cleaning up invalid references |
utils/constants.mjs |
Defines shared YAML_STRINGIFY_OPTIONS constant for consistent serialization |
| Multiple agent files | Updates to use centralized YAML_STRINGIFY_OPTIONS instead of inline options |
agents/clear/clear-generated-pages.mjs |
Removes unused results from return value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agents/plan/user-remove-page/remove-invalid-links-from-page.mjs
Outdated
Show resolved
Hide resolved
lban2049
previously approved these changes
Nov 12, 2025
agents/plan/user-remove-page/remove-invalid-links-from-page.mjs
Outdated
Show resolved
Hide resolved
wangshijun
reviewed
Nov 12, 2025
Contributor
wangshijun
left a comment
wangshijun
left a comment
There was a problem hiding this comment.
新增的代码有些需要单元测试覆盖，可以都加上
wangshijun
reviewed
Nov 12, 2025
lban2049
reviewed
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Major Changes
Screenshots
Test Plan
Checklist
dependenciesordevDependencies.pnpm-lock.yaml).Summary by AIGNE
Release Notes
New Features:
Bug Fixes:
Refactor: