Skip to content

Extend CI to verify editable, non-editable, and GitHub install methods#52

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/extend-ci-install-methods-testing
Draft

Extend CI to verify editable, non-editable, and GitHub install methods#52
Copilot wants to merge 4 commits intomainfrom
copilot/extend-ci-install-methods-testing

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Plan: Extend CI to verify all supported install methods

Summary

Extended CI to verify all three supported install methods (editable, non-editable, and GitHub) using a matrix strategy for better maintainability.

Changes Made

  • Explore repository structure and understand current CI workflow
  • Add test jobs for non-editable installs (pip install ./accordo)
  • Add test jobs for GitHub installs (pip install git+https://github.com/AMDResearch/intellikit.git@sha#subdirectory=accordo)
  • Ensure each install method is tested with import verification for all packages
  • Test non-editable install locally for pure Python packages (verified working)
  • Verify the CI configuration is correct and complete
  • Code review completed and addressed
  • Add security: set minimal GITHUB_TOKEN permissions (contents: read)
  • Run final security check with CodeQL (0 issues found)
  • Refactor to use matrix strategy per reviewer feedback

Implementation Details

Single test job with matrix strategy:

  • Matrix dimensions: 6 packages × 3 install methods = 18 test combinations
  • Packages: accordo, linex, metrix, nexus, rocm_mcp, uprof_mcp
  • Install methods: editable, non-editable, github
  • fail-fast: false ensures all combinations run even if one fails
  • Conditional checkout: only checkout for editable/non-editable (github installs directly from repo)

Install methods tested:

  1. Editable: pip install -e <package>
  2. Non-editable: pip install ./<package>
  3. GitHub: pip install git+https://github.com/AMDResearch/intellikit.git@${{ github.sha }}#subdirectory=<package>

Import verification:

  • Each install is followed by python3 -c 'import <package>' to verify correct installation

Isolation:

  • Each test step runs in isolated container overlay (via container_exec.sh)
  • Ensures no contamination between tests

Security:

  • Minimal workflow permissions (contents: read) following security best practices
  • CodeQL scan passed with 0 alerts
Original prompt

This section details on the original issue you should resolve

<issue_title>Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable).</issue_title>
<issue_description>## Summary
Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable).

Install methods to test

  1. Editablepip install -e accordo (and same for linex, metrix, nexus) from repo root; then python3 -c 'import accordo' (and equivalents).
  2. Non-editablepip install . (or pip install ./accordo, etc.) then the same import checks.
  3. From GitHubpip install git+https://github.com/AMDResearch/intellikit.git#subdirectory=accordo (and equivalents for other packages / root) then import checks.

Rationale

  • Editable works today; non-editable can fail (e.g. scikit-build-core / mixed CMake+Python).
  • Installing from GitHub ensures the published install path works for users.
  • Running all three in CI will prevent regressions when changing layout or build config.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 18, 2026 18:57
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot AI changed the title [WIP] Extend CI to verify all supported install methods Extend CI to verify editable, non-editable, and GitHub install methods Feb 18, 2026
Copilot AI requested a review from mawad-amd February 18, 2026 19:03
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable).

2 participants