Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 22, 2025

Enable pickling of Solver and SolverPtr. For now, only with limited functionality and through storing solver settings in HDF5 files.

Related to #1126.

@dweindl dweindl self-assigned this Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.79%. Comparing base (9ccd079) to head (e58d899).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/swig_wrappers.py 11.11% 8 Missing ⚠️
include/amici/solver_cvodes.h 0.00% 1 Missing ⚠️
include/amici/solver_idas.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
- Coverage   76.52%   75.79%   -0.73%     
==========================================
  Files         308      308              
  Lines       19529    19540      +11     
  Branches     1499     1500       +1     
==========================================
- Hits        14944    14810     -134     
- Misses       4572     4717     +145     
  Partials       13       13              
Flag Coverage Δ
cpp 72.89% <9.09%> (-0.04%) ⬇️
cpp_python 38.26% <9.09%> (-0.02%) ⬇️
petab 38.86% <9.09%> (-0.03%) ⬇️
python 69.62% <9.09%> (-0.04%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/solver.h 100.00% <ø> (ø)
include/amici/solver_cvodes.h 50.00% <0.00%> (-50.00%) ⬇️
include/amici/solver_idas.h 50.00% <0.00%> (-50.00%) ⬇️
python/sdist/amici/swig_wrappers.py 91.96% <11.11%> (-7.07%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the pickle_solver branch 4 times, most recently from b3f9b83 to f6d1a29 Compare October 27, 2025 05:47
Enable pickling of `Solver` and `SolverPtr`. For now, only with limited functionality and through storing solver settings in HDF5 files.
@dweindl dweindl marked this pull request as ready for review October 27, 2025 06:26
@dweindl dweindl requested a review from a team as a code owner October 27, 2025 06:26
@dweindl dweindl merged commit d20b5b5 into AMICI-dev:main Oct 27, 2025
16 of 18 checks passed
@dweindl dweindl deleted the pickle_solver branch October 27, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants