CMake: 3.25+ #4773
Open
CMake: 3.25+ #4773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use features of `FindCUDAToolkit` for nvtx3 that are CMake 3.25+. Modernize and remove pre CMake 3.20 CUDA logic.
Unsupported
Member
Author
|
@WeiqunZhang can you please remove |
Member
|
Should we also update this? amrex/Tools/CMake/AMReXCUDAOptions.cmake Line 61 in e727197 Also don't think we need to worry about CUDA 10 anymore. |
WeiqunZhang
approved these changes
Nov 10, 2025
jmsexton03
reviewed
Nov 10, 2025
| target_link_libraries(amrex_${D}d PUBLIC CUDA::cusparse) | ||
| endif () | ||
|
|
||
| if(CMAKE_CUDA_COMPILER_VERSION VERSION_LESS 11.2) |
Contributor
There was a problem hiding this comment.
https://amrex-codes.github.io/amrex/docs_html/GPU_Chapter.html
Do we need to update the docs (not that I expect someone to find cuda 11.0 or 11.1)
Member
Author
|
Yes, couple of options we need to refresh now. E.g., add support for LTO on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already use features of
FindCUDAToolkitfor nvtx3 that are CMake 3.25+. Modernize and remove pre CMake 3.20 CUDA logic.Additional background
CMake 3.25 was released in November 2022 and is widely available and very easy to install as a user, if missing.
Also a bit of prep for #4572
As in WarpX, we disable SENSEI CI because the package has gone unsupported and deprecated for a few years now.
Checklist
The proposed changes: