Split the SAL into two modules to eliminate several circular dependencies#18
Open
Split the SAL into two modules to eliminate several circular dependencies#18
Conversation
One module contains the SAL and the other contains target dependencies. This eliminates definition-based circular dependencies from the SAL.
Contributor
Author
|
(This is a prototype and not expected to be merged for beta) Don't panic, @bogdanm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This split means that the notional dependency tree from sockets looks like:
(pruned for readability)
Since
saldoes not have a targetDependency onsal-stack-lwip, there is no circular dependency between the two. This means that a new sal can be published without breaking sal-stack-lwip.@autopulated @0xc0170 @bogdanm