[refactor/#229] 1차 리팩(1/4회의 수정사항 반영 완료) #230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeeeeaaan
changed the title
2ghrms
approved these changes
Jan 19, 2026
Member
2ghrms
left a comment
2ghrms
left a comment
There was a problem hiding this comment.
고생하셨습니다~~ PR 제목의 키워드만 대문자로 수정하면 좋을 것 같아요~
| @Transactional | ||
| public StudentResponseDTO.myPartnership getMyPartnership(Long studentId, int year, int month) { | ||
| List<PartnershipUsage> usages = partnershipUsageRepository.findByYearAndMonth(studentId, year, month); | ||
| @Transactional(readOnly=true) |
Member
There was a problem hiding this comment.
@transactional 관련해서 가능하면 클래스에 달아주고 필요시 메소드별로 readOnly를 오버라이딩 해주는게 좋을 것 같습니다
| } | ||
|
|
||
|
|
||
| public static PaperContentResponseDTO toContentResponse(PaperContent content) { |
Member
There was a problem hiding this comment.
converter를 더이상 사용하지 않기로 했으니 convert 관련 로직은 해당 DTO 내부로 옮기면 될 것 같습니다~
| // addUserToSession에서 자동으로 키가 생성되므로 이 메서드는 비워두거나, | ||
| // 만료 시간 설정 등 초기화 로직을 넣을 수 있습니다. | ||
| // 예: 10분 후 만료 | ||
| private String getInfoKey(Long sessionId) { |
Member
There was a problem hiding this comment.
private 메소드는 맨 뒤로 이동 시키는 게 가독성 및 추상화, Step-down Rule에 의해 관례적이니 클래스의 아래쪽으로 이동시키면 좋을 것 같습니다~
| // 세션 생성 직후 만료 시간을 5분으로 설정 | ||
| timeoutManager.scheduleTimeout(sessionId, Duration.ofMinutes(10));// TODO: 나중에 5분으로 변경 | ||
|
|
||
| // 세션 여는 대표자는 제일 먼저 인증 |
| } else { | ||
| messagingTemplate.convertAndSend("/certification/progress/" + sessionId, | ||
| new CertificationProgressResponseDTO("progress", currentCertifiedNumber, null, sessionManager.snapshotUserIds(sessionId))); | ||
| new CertificationProgressResponseDTO("progress", currentCount, null, currentCertifiedUserIds)); |
Member
There was a problem hiding this comment.
이런식으로 null이 들어간 건 필드를 지우는게 좋을 것 같습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
비고 (Optional)