Fix: passing empty request details for bulk-export#1
Open
GoodOliver wants to merge 1 commit intomasterfrom
Open
Fix: passing empty request details for bulk-export#1GoodOliver wants to merge 1 commit intomasterfrom
GoodOliver wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When running a bulk‐export ($export) against a partitioned HAPI FHIR server, the export job fails in the “write to binaries” step with:
Root cause: the collision‐check and final binaryDao.update(...) calls in NdJsonResourceWriter use a brand‐new SystemRequestDetails() (with no partition info), so the partition‐identification interceptor can’t resolve which tenant to read/write under.
Updates
In NdJsonResourceWriter.accept(...):
Replace the new SystemRequestDetails() with the request details with partition information.
Use that same SystemRequestDetails instance for both: