Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Emphasis infotext #16837

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Haoming02
Copy link
Contributor

Description

  • Simple Description: Currently, in certain situations (see Repro), the Emphasis parameter would be missing from the infotext
  • Summary of Changes: Moved the code that adds this parameter into create_infotext function

Repro

  1. Enable Persistent cond cache in settings
  2. Generate an image that contains emphasis
    • notice the Emphasis: ... in infotext
  3. Generate again with the exact same parameters (Seed can vary)
    • notice the Emphasis: ... is now missing
  4. Reload UI
  5. Click the Read generation parameters button (↙️)
  6. See the Override settings now shows up as a result
  • TL;DR: Currently, the Emphasis parameter is added during CLIP processing. So if you enable the Persistent cond cache, the CLIP no longer gets called in subsequent generations, thus missing the parameter.

Checklist

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 10, 2025

I also notice the issue with the entirer sd_hijack_clip.py
I have a WIP that I haven't had time to finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants