Onion Skin Management#774
Closed
pbergeron-adsk wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Closed
Onion Skin Management#774pbergeron-adsk wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
pbergeron-adsk wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
pbergeron-adsk
changed the title
bernie-laberge
changed the title
cedrik-fuoco-adsk
changed the title
Contributor
Author
|
Closing because this PR was implemented another way with the hold & ghost functionality |
Contributor
Author
|
closed due to different/similar implementation of hold and ghost |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a take-over of the following PR for the excellent work from @mamouth13 found here: #498
Summarize your change.
This implements onion skin management. From the original PR text:
Added 5 properties into the PaintIPNode node:
onionShow : enabled/disabled the drawing of onionSkin (default is false).
onionBeforeFrame: the number of frames BEFORE a stroke on which the onionSkins will be drawn (default is 5).
onionAfterFrame: the number of frames AFTER a stroke on which the onionSkins will be drawn (default is 5).
onionBeforeColor: the color used to draw onionSkin BEFORE (default is red).
onionAfterColor: the color used to draw onionSkin AFTER (default is green).
Paint::PolyLine and Paint::Text now manage those new properties and draw onionSkin on previous / next frames with the appropriate fading out colors.
Modified the annotate rv-package:
Modified drawpane.ui to add the appropriate Ui to manage the above new properties.
Modified annotate_mode.mu to properly handle the colorChooser with those new Ui.
Describe the reason for the change.
There is no change from the original PR - except for resolving merge conflicts and bringing up to date with the latest OpenRV main.
Describe what you have tested and on which operating system.
macOS
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.