Repository navigation
Add vscode style ".acode" folder and file structure for settings and extensions. - #3093
Open
codewithchai0605 wants to merge 5 commits into
Open
codewithchai0605 wants to merge 5 commits into
codewithchai0605 wants to merge 5 commits into
Conversation
- Implement tests for workspaceExtensions including validation of plugin IDs, parsing of extension recommendations, and handling of hostile input. - Introduce tests for workspaceSettings covering project settings allowlist, parsing of project settings, and validation of individual settings like tabSize and formatOnSave. - Ensure both test files check for frozen results and handle edge cases such as invalid JSON and prototype pollution.
Contributor
[Medium impact] The reviewed changes appear safe to merge; both previously reported problems are fixed. SummaryAdds project-level settings and plugin recommendations through a
Both numbered findings from the previous review are addressed. No new actionable issues were found. Reviews (7) · Last reviewed commit: "Enhance EditorManager and workspace func..." · Reviewed by Greptile |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
codewithchai0605
force-pushed
the
feat/acode-workspace
branch
from
November 17, 2026 11:09
c296faf to
2c2742c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin recommendations.
A project can suggest plugins that suits it. This is only ever a suggestion nothing here installs, enables or runs anything.
it can be used like this, Plugin recommendations: the contents of
.acode/extensions.json{ "recommendations": ["acode.plugin.example"] }Note: This requires the backend to update the existing search api to also accepts query like "id:plugin.id" like "mode:pluginId".
Project settings:
It allows to change the project level settings without editing their globals settings.
This feature is not implemented completely. It can be improved much.