Feature/atr 777 dev graphs and graph extensions not sealed #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SENya1990
changed the base branch from
dev
to
feature/ATR-728-dev-graph-declaration-diagnostic
There was a problem hiding this comment.
Pull Request Overview
This PR implements two new diagnostics (PX1112 and PX1113) with code fixes to enforce proper declaration modifiers for Acumatica graphs and graph extensions. The diagnostics ensure that generic graphs/extensions are declared as abstract and that no graphs/extensions are sealed, which is required for Acumatica's dynamic type generation and customization mechanism.
Key Changes:
- Added PX1112 diagnostic to detect non-abstract generic graphs and graph extensions
- Added PX1113 diagnostic to detect sealed graphs and graph extensions
- Implemented a unified code fix that adds
abstractmodifier or removessealedmodifier as appropriate
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GraphAndGraphExtensionDeclarationAnalyzer.cs | New analyzer implementing PX1112 and PX1113 diagnostics for graph/extension declarations |
| TypeModifiersFix.cs | New code fix provider that adds abstract or removes sealed modifiers, handling both partial and non-partial types |
| PXGraphAnalyzer.cs | Registered the new GraphAndGraphExtensionDeclarationAnalyzer |
| Descriptors.cs | Added diagnostic descriptors for PX1112 and PX1113 |
| Resources.resx | Added localized strings for diagnostic titles and code fix messages |
| DiagnosticsShortName.resx | Added short names for the new diagnostics |
| GenericNonAbstractGraphsAndGraphExtensionsTests.cs | Test suite for PX1112 diagnostic and code fix |
| SealedGraphsAndGraphExtensionsTests.cs | Test suite for PX1113 diagnostic and code fix |
| Test source files | Various test input and expected output files for both diagnostics |
| PX1112.md, PX1113.md | Documentation for the new diagnostics |
| Summary.md | Updated diagnostic summary table |
Files not reviewed (2)
- src/Acuminator/Acuminator.Analyzers/DiagnosticsShortName.Designer.cs: Language not supported
- src/Acuminator/Acuminator.Analyzers/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dropsonic
approved these changes
Oct 27, 2025
Base automatically changed from
feature/ATR-728-dev-graph-declaration-diagnostic
to
dev
November 3, 2025 22:28
Contributor
Author
|
The documentation review will be done in a separate PR |
SENya1990
deleted the
feature/ATR-777-dev-graphs-and-graph-extensions-not-sealed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE INTO
devBRANCH AFTER #621Implemented PX1113 diagnostic to report sealed graphs and graph extensions.
Changes Overview
sealedmodifier